billy/ 521 Consistent Search #758
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #758 +/- ##
===========================================
- Coverage 87.87% 87.75% -0.12%
===========================================
Files 94 94
Lines 1583 1601 +18
Branches 73 88 +15
===========================================
+ Hits 1391 1405 +14
- Misses 181 182 +1
- Partials 11 14 +3
|
|
hey @okwme we have a "codecov can't go down" policy so i'll add some tests! |
|
@jolesbi bless u for the bump! yours didn't pull us out of the red tho did it? was also surprised mine was in red after the first fail and the subsequent beefing that already took place... |
|
i wanted to get it in! but no, i couldn't get it through... seems very strange to me. |
|
Could you improve the coverage for PageBlocks, PageTransactions, PageStaking (probably copy pasting the test for somethingToSearch)? |
|
the only thing not covered in PageBlocks, PageTransactions or PageStaking is Mousetrap. We shouldn't be testing that tho, right? PageBlocks: |
i did that here 1ff25d1 |
|
Very good PR. :) |
Bumps [eslint](https://github.com/eslint/eslint) from 6.7.0 to 7.0.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.7.0...v7.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Closes #521
Description:
made search consistent as per @jolesbi recommendations on #521
❤️ Thank you!